This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Wallet connect meta data #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
W3stside
reviewed
May 6, 2021
|
|
||
| import WalletModal from 'components/WalletModal' | ||
| import { Web3StatusInner } from './Web3StatusMod' | ||
| import useRecentActivity, { TransactionAndOrder } from 'hooks/useRecentActivity' | ||
| import { OrderStatus } from 'state/orders/actions' | ||
| import { useWalletInfo } from '@src/custom/hooks/useWalletInfo' |
alfetopito
approved these changes
May 6, 2021
alfetopito
force-pushed
the
wallet-connect-meta-data
branch
from
4b8f5bb to
64ea861
Compare
This was referenced May 13, 2021
* New hook for getting a Web3Provider instance for the current provider * Setting isSmartContractWallet flag * Oopsie, only check when both are set Co-authored-by: Leandro Boscariol <[email protected]>
* Added set with wallets not supported via WC * Checking and setting flag for unsupported wallets Co-authored-by: Leandro Boscariol <[email protected]>
* Add jsx-a11y eslint plugin to rules * When wallet is not supported, show a⚠️ besides the address + tooltip * Show wallet icon if any from metadata * Show wallet name if any on account details * Disable swap when wallet is not supported * Make currencies optional on UnsupportedCurrencyFooter * Adding custom/warning wallet images to account detail on header * Updated tooltip text * Simplified walletName destruction * Refactored wallet name fetching * Adding WalletConnect sufix for WC wallets that have a name set Co-authored-by: Leandro Boscariol <[email protected]>
* Added FAQ entry for unsupported tokens * Added FAQ link to unsupported tokens message * Update src/custom/pages/Faq/index.tsx Co-authored-by: David <[email protected]> * Update src/custom/pages/Faq/index.tsx Co-authored-by: David <[email protected]> * Update src/custom/pages/Faq/index.tsx Co-authored-by: David <[email protected]> * Update src/custom/pages/Swap/SwapMod.tsx Co-authored-by: David <[email protected]> * Replace gas free with gasless * Added paragraphs between unsupported wallet text Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: Alex V <[email protected]> Co-authored-by: David <[email protected]>
…a-data Opting for a merge commit to keep history of PRs already merged into this one
|
Re-tested with all supported and unsupported wallets that I currently have access to, which are: Smart contract
Don't support signature
Working fine
|
This was referenced May 25, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jun 16, 2021
# Update 2021/06/15 TokenPocket has released their update and it's now working flawlessly :) # Summary Closes #673 ## Note I'm opening this PR to allow TP team to test their fix(TP-Lab/tp-android#16), since the wallet was disabled via WalletConnect on #597 # Testing Using the PR's url: 1. Connect via WalletConnect using TokenPocket wallet - [ ] The wallet should not be disabled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR to better handle Wallet Connect.
Motivation
This PR adds a new hook which aims to simplify the wallet logic.
The initial motivation was to have information about what is the connected wallet (not just the provider, but the actual wallet). This will be base to progressively enable wallets depending on their support.
Scope
However the scope of this PR is slightly bigger. It became evident that the wallet logic is a bit complex, and there's many conditional rendering depending on introspection in the providers, and connected wallet information (see for example Web3StatusInner, Web3StatusInner, etc..)
This PR tries to create a simple interface that would give us all relevant wallet information in something closer to what the react component would want to use. For this, a new hook
useWalletInfois implemented.This hook exposes the following information:
Not all these props will be implemented in this PR, but it's the goal to define a basic abstraction of the wallet, implement the basic ones.
So
isSupportedWalletandisSmartContractWalletare just place holders for futur PRs.The most relevant part in this PR will be
walletName, which will show you the wallet name if available. This comes from the wallet connect peer meta-info that wallets provide.The icon for now only contains information of the same metada of wallet connect, however, we could have some famous wallets icons and resolve the image by name of the wallet. i.e. Argent don't send the icon, but send the wallet name
Test
Connect with Metamask
Connect with metamask and observe the info provided by the hook in the log:
Connect with WC using different wallets